Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add missing options for timers on config.ts file #10632

Merged
merged 3 commits into from Oct 14, 2020

Conversation

@ftonato
Copy link
Contributor

@ftonato ftonato commented Oct 13, 2020

Summary

@jest/types config in Config.ts has missing value(s) for timers in two variables InitialOptions and DefaultOptions.


Closes #10609

Copy link
Collaborator

@jeysal jeysal left a comment

Thanks for the PR!

packages/jest-types/src/Config.ts Outdated Show resolved Hide resolved
@SimenB
SimenB approved these changes Oct 14, 2020
Copy link
Collaborator

@SimenB SimenB left a comment

Thanks! Could you add an entry to the changelog as well?

@ftonato
Copy link
Contributor Author

@ftonato ftonato commented Oct 14, 2020

Yes, I will do it!

@SimenB SimenB merged commit e84a70c into facebook:master Oct 14, 2020
14 of 16 checks passed
14 of 16 checks passed
cleanup-runs
Details
Running TypeScript compiler & ESLint
Details
Node v10.x on ubuntu-latest
Details
Node v10.x on macOS-latest
Details
Node v10.x on windows-latest
Details
Node v12.x on ubuntu-latest
Details
Node v12.x on macOS-latest
Details
Node v12.x on windows-latest
Details
Node v13.x on ubuntu-latest
Details
Node v13.x on macOS-latest Node v13.x on macOS-latest
Details
Node v13.x on windows-latest
Details
Node v14.x on ubuntu-latest Node v14.x on ubuntu-latest
Details
Node v14.x on macOS-latest
Details
Node v14.x on windows-latest
Details
Facebook CLA Check Contributor License Agreement is valid!
Details
facebook.jest #20201014.9 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.