Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "moduleLoader" to "runtime" and "extraGlobals" to "sandboxInjectedGlobals" configuration options #10817

Merged
merged 14 commits into from Feb 24, 2022

Conversation

anje123
Copy link
Contributor

@anje123 anje123 commented Nov 13, 2020

Summary

This is part of the fixes for this issue #7185

  • rename moduleLoader to runtime
  • rename extraGlobals to sandboxInjectedGlobals

Test plan

Existing tests.

@SimenB SimenB merged commit 1cb30a1 into facebook:main Feb 24, 2022
3 of 9 checks passed
@SimenB SimenB deleted the rename-configuration-options branch Feb 24, 2022
@SimenB
Copy link
Collaborator

SimenB commented Feb 24, 2022

Thanks @anje123!

@github-actions
Copy link

github-actions bot commented Mar 27, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants