Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add integration test using browser-resolve #11140

Merged
merged 4 commits into from
Mar 2, 2021

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Mar 2, 2021

Summary

Closes #11139. There is no bug in Jest, but our docs on how to use browser-resolve are wrong.

/cc @slorber I've modified the docs here since they are horribly wrong. Hopefully it won't create an issue with the new docusaurus site. 🤞

Test plan

Green CI

@SimenB SimenB merged commit 78af379 into jestjs:master Mar 2, 2021
@SimenB SimenB deleted the browser-resolve branch March 2, 2021 18:33
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest using incorrect dependency in JSDOM (Node deps not browser deps)
2 participants