Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw correct error when loading ESM with require #11260

Merged
merged 2 commits into from
Apr 1, 2021

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 1, 2021

Summary

Fixes #11258

Test plan

E2E test added

@SimenB SimenB merged commit f10cad1 into jestjs:master Apr 1, 2021
@SimenB SimenB deleted the error-loading-cjs-from-esm branch April 1, 2021 22:56
@SimenB SimenB mentioned this pull request Apr 7, 2021
21 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

require()ing a file shouldn't automatically make it CJS
2 participants