Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing collectCoverage after init (#11348) #11353

Merged
merged 4 commits into from
Apr 30, 2021
Merged

fix: missing collectCoverage after init (#11348) #11353

merged 4 commits into from
Apr 30, 2021

Conversation

davc0n
Copy link
Contributor

@davc0n davc0n commented Apr 28, 2021

Summary

#11348

Test plan

  • jest --init
  • reply positively to collect coverage question
  • collectCoverage: true is present in jest config

@facebook-github-bot
Copy link
Contributor

Hi @davc0n!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@SimenB SimenB linked an issue Apr 29, 2021 that may be closed by this pull request
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! if you update the snapshot in packages/jest-cli/src/init/__tests__/init.test.js CI should be happy as well 🙂

@davc0n
Copy link
Contributor Author

davc0n commented Apr 29, 2021

didn't find those tests before, should be ok now. CLA signed as well, but it keeps failing...

@codecov-commenter
Copy link

Codecov Report

Merging #11353 (def2fab) into master (64d5983) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11353      +/-   ##
==========================================
- Coverage   64.16%   64.15%   -0.02%     
==========================================
  Files         308      308              
  Lines       13515    13515              
  Branches     3294     3294              
==========================================
- Hits         8672     8670       -2     
- Misses       4129     4130       +1     
- Partials      714      715       +1     
Impacted Files Coverage Δ
packages/jest-cli/src/init/generateConfigFile.ts 96.55% <ø> (ø)
packages/expect/src/utils.ts 94.83% <0.00%> (-1.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64d5983...def2fab. Read the comment docs.

@SimenB
Copy link
Member

SimenB commented Apr 29, 2021

I have no idea what to do about the CLA thing. @JoelMarcey do you have any idea?

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@JoelMarcey
Copy link
Contributor

I think we are good now here, right?

@SimenB
Copy link
Member

SimenB commented Apr 30, 2021

Yep, thanks @JoelMarcey!

@SimenB SimenB merged commit c900f59 into jestjs:master Apr 30, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jest --init does not enable collectCoverage
5 participants