Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for <C-u> to clear line in prompt #11358

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

parthsharma2
Copy link
Contributor

Summary

Added support for clearing the line when <C-u> is pressed in a watch mode pattern prompt. Resolves #11296

Test plan

Added a test case that tests this change. Wasn't able to test it manually because of the jest-watch-typeahead plugin that uses the published version of jest-watcher Refer: #11296 (comment)

Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@SimenB regarding your concern around "where does it end" as I commented in the issue I think we can happily accept further contributions for the things listed there, don't think it needs to come all at once though, this is a good start. Idk if you have other things to raise?- requested review

@jeysal jeysal requested a review from SimenB April 29, 2021 16:59
@SimenB SimenB merged commit 49188c3 into jestjs:master Apr 30, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<C-u> to clear watch mode pattern prompt
4 participants