Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled import/no-unresolved rule in packages/**/*.ts #11477

Closed

Conversation

wafuwafu13
Copy link

Summary

I read CONTRIBUTING.md and run yarn test but failed.
All errors were import/no-unresolved in packages/**/*.ts so I disabled this rule.

# fetch this repo

$ git clone git@github.com:wafuwafu13/jest.git

$ cd jest

$ yarn install # success

$ brew install hg
$ yarn test # failed

スクリーンショット 2021-05-29 15 57 46

Test plan

@facebook-github-bot
Copy link
Contributor

Hi @wafuwafu13!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #11477 (4985ccf) into master (c05521f) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11477   +/-   ##
=======================================
  Coverage   68.94%   68.95%           
=======================================
  Files         312      312           
  Lines       16309    16309           
  Branches     4721     4721           
=======================================
+ Hits        11245    11246    +1     
+ Misses       5036     5035    -1     
  Partials       28       28           
Impacted Files Coverage Δ
packages/expect/src/utils.ts 96.13% <0.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c05521f...4985ccf. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@wafuwafu13
Copy link
Author

There's something wrong with my local environment ...? #11502 (comment)

@SimenB
Copy link
Member

SimenB commented Jun 3, 2021

You need to build the repo first (yarn build, step 6 in the guide), then the warning shouldn't trigger 🙂

@SimenB SimenB closed this Jun 3, 2021
@github-actions
Copy link

github-actions bot commented Jul 4, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants