Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the syntax error message more helpful for TS users #11807

Merged
merged 5 commits into from Sep 20, 2021

Conversation

@hexagonrecursion
Copy link
Contributor

@hexagonrecursion hexagonrecursion commented Sep 2, 2021

Summary

I got this error when trying to use jest with typescript. Turns out the info I needed was on https://jestjs.io/docs/getting-started#using-typescript : I needed to install babel and create babel.config.js

Test plan

none

I got this error when trying to use jest with typescript. Turns out the info I needed was on https://jestjs.io/docs/getting-started#using-typescript : I needed to install babel and create babel.config.js
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Sep 2, 2021

Codecov Report

Merging #11807 (106cad5) into main (98f10e6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #11807   +/-   ##
=======================================
  Coverage   69.04%   69.04%           
=======================================
  Files         312      312           
  Lines       16366    16366           
  Branches     4746     4746           
=======================================
  Hits        11300    11300           
  Misses       5039     5039           
  Partials       27       27           
Impacted Files Coverage Δ
...est-transform/src/enhanceUnexpectedTokenMessage.ts 50.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98f10e6...106cad5. Read the comment docs.

Copy link
Collaborator

@SimenB SimenB left a comment

thanks! could you add a changelog entry as well?

@@ -45,6 +45,7 @@ Here's what you can do:
${DOT}If you are trying to use ECMAScript Modules, see ${chalk.underline(
'https://jestjs.io/docs/ecmascript-modules',
)} for how to enable it.
${DOT}If you are trying to use TypeScript, see https://jestjs.io/docs/getting-started#using-typescript
Copy link
Collaborator

@SimenB SimenB Sep 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should use chalk.underline as above

@hexagonrecursion hexagonrecursion requested a review from SimenB Sep 19, 2021
SimenB
SimenB approved these changes Sep 20, 2021
Copy link
Collaborator

@SimenB SimenB left a comment

thanks!

@SimenB SimenB changed the title Make the syntax error message more helpful make the syntax error message more helpful for TS users Sep 20, 2021
@SimenB SimenB merged commit 6175fa1 into facebook:main Sep 20, 2021
27 of 30 checks passed
@hexagonrecursion hexagonrecursion deleted the patch-2 branch Sep 21, 2021
AndrewSouthpaw added a commit to AndrewSouthpaw/jest that referenced this issue Sep 23, 2021
…nsform-ignore-patterns

* 'main' of https://github.com/facebook/jest: (38 commits)
  chore: update `npm` instructions in README (facebook#11890)
  chore: force patched version of ansi-regex (facebook#11889)
  chore: update lockfile after publish
  v27.2.1
  chore: update changelog for release
  make the syntax error message more helpful for TS users (facebook#11807)
  fix: include path to test file in "after teardown" error (facebook#11885)
  docs: add link to the typescript integration instructions (facebook#11806)
  fix: properly return mocks when using jest.isolatedModules (facebook#11882)
  chore: remove node version pinning from CI (facebook#11866)
  chore: remove node 13 as condition in some tests (facebook#11880)
  chore: fix typo in docs
  chore: update lockfile after publish
  v27.2.0
  chore: roll new website version
  chore: update changelog for release
  chore: update lock
  feat: support `conditions` from test environments (facebook#11863)
  Revert "chore: remove unneeded yarn patch for react native (facebook#11853)"
  chore: supress experimental warnings in tests
  ...
@github-actions
Copy link

@github-actions github-actions bot commented Oct 22, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants