-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include path to test file in "after teardown" error #11885
Conversation
Codecov Report
@@ Coverage Diff @@
## main #11885 +/- ##
==========================================
- Coverage 68.93% 68.87% -0.07%
==========================================
Files 312 312
Lines 16414 16432 +18
Branches 4761 4768 +7
==========================================
+ Hits 11315 11317 +2
- Misses 5072 5088 +16
Partials 27 27
Continue to review full report at Codecov.
|
…nsform-ignore-patterns * 'main' of https://github.com/facebook/jest: (38 commits) chore: update `npm` instructions in README (jestjs#11890) chore: force patched version of ansi-regex (jestjs#11889) chore: update lockfile after publish v27.2.1 chore: update changelog for release make the syntax error message more helpful for TS users (jestjs#11807) fix: include path to test file in "after teardown" error (jestjs#11885) docs: add link to the typescript integration instructions (jestjs#11806) fix: properly return mocks when using jest.isolatedModules (jestjs#11882) chore: remove node version pinning from CI (jestjs#11866) chore: remove node 13 as condition in some tests (jestjs#11880) chore: fix typo in docs chore: update lockfile after publish v27.2.0 chore: roll new website version chore: update changelog for release chore: update lock feat: support `conditions` from test environments (jestjs#11863) Revert "chore: remove unneeded yarn patch for react native (jestjs#11853)" chore: supress experimental warnings in tests ...
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
The logging can happen long after the test has been printed as
PASS
to the user, so let's include the test file in the message to make it easier to track down (not super useful in sync situations as the stack trace should include it, but that doesn't happen in async contexts)Test plan
Green CI