Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call destroy on v8-to-istanbul converters to free memory #11896

Merged
merged 3 commits into from Sep 27, 2021

Conversation

@SimenB
Copy link
Collaborator

@SimenB SimenB commented Sep 27, 2021

Summary

See istanbuljs/v8-to-istanbul#161

Test plan

Green CI

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Sep 27, 2021

Codecov Report

Merging #11896 (5ea40eb) into main (341843f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11896      +/-   ##
==========================================
- Coverage   68.73%   68.73%   -0.01%     
==========================================
  Files         322      322              
  Lines       16580    16582       +2     
  Branches     4784     4784              
==========================================
  Hits        11397    11397              
- Misses       5150     5152       +2     
  Partials       33       33              
Impacted Files Coverage Δ
packages/jest-reporters/src/CoverageReporter.ts 59.89% <0.00%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 341843f...5ea40eb. Read the comment docs.

Loading

@SimenB SimenB merged commit 7b9b6f8 into facebook:main Sep 27, 2021
28 of 30 checks passed
Loading
@SimenB SimenB deleted the v8-to-istanbul branch Sep 27, 2021
@github-actions
Copy link

@github-actions github-actions bot commented Oct 28, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

Loading

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants