-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: not to break on expect
matcher extension overwrite
#11978
Conversation
Looks good. I am the one who broke this, so... thanks for fixing! @SimenB Would it make sense to add |
Good call @mrazauskas, added that 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @blaky!
expect
matcher extension overwrite
@SimenB thank you for the improvements and merging this PR. Do you have any ETA on when this could be released? |
Thanks for the quick response 👍🏻 😆 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Before #11949 it was possible to overwrite expect extensions. With this change I recover that functionality by adding
configurable: true
to theObject.defineProperty
call which adds the extensions to the expect object.Please find more the details about the issue and a reproduction repo at #11977
Test plan
I added a unit test which ensure that this issue doesn't get reintroduced again to jest.