Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add performance global to nodejs environment #12002

Merged
merged 6 commits into from Dec 31, 2021

Conversation

SimonSiefke
Copy link
Contributor

@SimonSiefke SimonSiefke commented Oct 27, 2021

Summary

Fixes #11629

Test plan

before:
before

after:
after

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Oct 27, 2021

Hi @SimonSiefke!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@Smrtnyk
Copy link

@Smrtnyk Smrtnyk commented Oct 27, 2021

can you fixup the second commit to the first one?
otherwise first commit standalone breaks the system

@SimenB SimenB closed this Oct 28, 2021
@SimenB SimenB reopened this Oct 28, 2021
@SimenB
Copy link
Collaborator

@SimenB SimenB commented Oct 28, 2021

Sorry, misclicked


can you fixup the second commit to the first one?

That's not an issue as we squash on merge. However, the CLA needs to be signed before we can merge this 🙂

@SimonSiefke
Copy link
Contributor Author

@SimonSiefke SimonSiefke commented Oct 28, 2021

I'm having trouble with the CLA: It says 500 Internal Server Error.

cla

Any ideas?

@SimenB
Copy link
Collaborator

@SimenB SimenB commented Oct 28, 2021

Right, same as #12001 (comment). I unfortunately have no idea, hopefully somebody at FB figures it out

@SimenB
Copy link
Collaborator

@SimenB SimenB commented Oct 29, 2021

Regarding cla: #12001 (comment)

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Oct 30, 2021

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Oct 30, 2021

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Dec 29, 2021

Codecov Report

Merging #12002 (2396f00) into main (5706d71) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12002      +/-   ##
==========================================
- Coverage   67.72%   67.71%   -0.01%     
==========================================
  Files         328      328              
  Lines       16993    16995       +2     
  Branches     4818     4819       +1     
==========================================
+ Hits        11508    11509       +1     
- Misses       5452     5453       +1     
  Partials       33       33              
Impacted Files Coverage Δ
packages/jest-environment-node/src/index.ts 62.50% <50.00%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5706d71...2396f00. Read the comment docs.

@SimenB SimenB merged commit 1b97264 into facebook:main Dec 31, 2021
32 of 34 checks passed
@SimenB
Copy link
Collaborator

@SimenB SimenB commented Dec 31, 2021

Thanks!

@github-actions
Copy link

@github-actions github-actions bot commented Jan 31, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants