Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jest-worker: Avoid crash when "--max-old-space-size" inside process.execArgv #12103

Merged
merged 2 commits into from Nov 30, 2021

Conversation

JonWallsten
Copy link
Contributor

@JonWallsten JonWallsten commented Nov 30, 2021

Summary

Complement to this PR: #12097

Node has previously updated the command line flag max_old_space_size to max-old-space-size, so we should support both in when filtering the flags.

Test plan

Verifying the RegExp should be sufficient.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Nov 30, 2021

Hi @JonWallsten!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

SimenB
SimenB approved these changes Nov 30, 2021
Copy link
Collaborator

@SimenB SimenB left a comment

thanks! could you add a changelog entry as well?

(and sign the CLA)

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Nov 30, 2021

Codecov Report

Merging #12103 (d8e4cbf) into main (5640f88) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12103   +/-   ##
=======================================
  Coverage   67.65%   67.66%           
=======================================
  Files         328      328           
  Lines       16990    16990           
  Branches     4817     4817           
=======================================
+ Hits        11495    11496    +1     
+ Misses       5462     5461    -1     
  Partials       33       33           
Impacted Files Coverage Δ
...kages/jest-worker/src/workers/NodeThreadsWorker.ts 93.61% <100.00%> (ø)
packages/expect/src/utils.ts 96.53% <0.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5640f88...d8e4cbf. Read the comment docs.

@JonWallsten
Copy link
Contributor Author

@JonWallsten JonWallsten commented Nov 30, 2021

@SimenB: Done! I didn't add another entry in 27.4.0 like the other PR. It felt redundant since it's just a complement. Is that OK?
The CLA is already signed. It was just really slow to report back.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Nov 30, 2021

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

SimenB
SimenB approved these changes Nov 30, 2021
Copy link
Collaborator

@SimenB SimenB left a comment

thanks!

@SimenB SimenB merged commit cc295f5 into facebook:main Nov 30, 2021
34 checks passed
@SimenB
Copy link
Collaborator

@SimenB SimenB commented Nov 30, 2021

@github-actions
Copy link

@github-actions github-actions bot commented Dec 31, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants