Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-config): replace jsonlint with parse-json #12316

Merged
merged 3 commits into from Feb 7, 2022

Conversation

SimenB
Copy link
Collaborator

@SimenB SimenB commented Feb 7, 2022

Summary

Instead of vendoring a super old jsonlint, let's just use parse-json which gives a better error with less code

Test plan

Green CI

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #12316 (739ec0d) into main (3a7e1c9) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12316   +/-   ##
=======================================
  Coverage   67.25%   67.25%           
=======================================
  Files         330      330           
  Lines       17354    17354           
  Branches     5074     5073    -1     
=======================================
  Hits        11671    11671           
  Misses       5651     5651           
  Partials       32       32           
Impacted Files Coverage Δ
...ges/jest-config/src/readConfigFileAndSetRootDir.ts 2.70% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a7e1c9...739ec0d. Read the comment docs.

@SimenB SimenB merged commit 932f78e into facebook:main Feb 7, 2022
32 of 33 checks passed
@SimenB SimenB deleted the remove-jsonlint branch Feb 7, 2022
@github-actions
Copy link

github-actions bot commented Mar 11, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants