Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest-core): Pass project config to globalSetup/globalTeardown as 2nd argument #12440

Merged

Conversation

ahnpnl
Copy link
Contributor

@ahnpnl ahnpnl commented Feb 20, 2022

Summary

Closes #12436

Test plan

Updated e2e tests

Green CI

@ahnpnl ahnpnl force-pushed the feat/project-config-global-setup-teardown branch 2 times, most recently from f9eec12 to fc820f7 Compare Feb 20, 2022
@ahnpnl ahnpnl marked this pull request as ready for review Feb 20, 2022
docs/Configuration.md Outdated Show resolved Hide resolved
docs/Configuration.md Outdated Show resolved Hide resolved
@ahnpnl ahnpnl force-pushed the feat/project-config-global-setup-teardown branch 2 times, most recently from 110606b to cce4adf Compare Feb 21, 2022
@ahnpnl ahnpnl force-pushed the feat/project-config-global-setup-teardown branch from cce4adf to 29f0422 Compare Feb 21, 2022
@ahnpnl ahnpnl requested a review from SimenB Feb 21, 2022
SimenB
SimenB approved these changes Feb 21, 2022
Copy link
Collaborator

@SimenB SimenB left a comment

thanks!

@SimenB SimenB merged commit 5d883fb into facebook:main Feb 21, 2022
27 checks passed
@ahnpnl ahnpnl deleted the feat/project-config-global-setup-teardown branch Feb 22, 2022
@github-actions
Copy link

github-actions bot commented Mar 25, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants