Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest-environment): Pass global config to Jest environment constructor #12461

Merged
merged 2 commits into from
Feb 23, 2022

Conversation

ahnpnl
Copy link
Contributor

@ahnpnl ahnpnl commented Feb 22, 2022

Summary

This is a BREAKING change, since we change the 1st argument in constructor from ProjectConfig to be an object which includes GlobalConfig and ProjectConfig, as suggested implementation in #12271

Closes #12271

Test plan

Updated unit tests and e2e tests

Green CI

@ahnpnl ahnpnl marked this pull request as ready for review February 22, 2022 21:52
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

docs/Configuration.md Outdated Show resolved Hide resolved
@SimenB SimenB merged commit 9c00942 into jestjs:main Feb 23, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Allow option to detect if jest is currently running in watch mode
3 participants