Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jest-haste-map): Remove legacy isRegExpSupported #12676

Merged
merged 2 commits into from
Apr 16, 2022

Conversation

robhogan
Copy link
Contributor

Summary

As the code comment says, this function existed to cater to Node < 9 users where negative lookbehind was not supported. Jest has long since dropped support for Node 8, so we can tidy up a bit and remove this function.

Test plan

Tests pass (covering negative lookbehind RegExp compilation) on all supported Node versions.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@SimenB SimenB merged commit 06040d3 into jestjs:main Apr 16, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants