Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): Lower Node requirement to 16.10 #12754

Merged
merged 3 commits into from Apr 27, 2022
Merged

Conversation

lukeapage
Copy link
Contributor

@lukeapage lukeapage commented Apr 27, 2022

Summary

Node JS 16.11 brings in a change that has significant memory and performance issues with Jest - #11956. It has been identified as a upstream bug, but it has not been fixed. Since people who use yarn get the engine enforced (or decide to opt out for all packages) this pushes people upgrading to Jest 28 on to the buggy node version, which for large projects makes jest unworkable and small projects slower. So, as agreed on the bug I am lowering the required node v16 minor version to allow this work-around to continue to work.

CHANGELOG.md Outdated Show resolved Hide resolved
SimenB
SimenB approved these changes Apr 27, 2022
Copy link
Collaborator

@SimenB SimenB left a comment

thanks!

@SimenB SimenB changed the title fix(*): Lower node requirement to 16.10 fix(*): Lower Node requirement to 16.10 Apr 27, 2022
@SimenB SimenB merged commit 9241321 into facebook:main Apr 27, 2022
82 of 89 checks passed
@lukeapage lukeapage deleted the node-16-10 branch Apr 27, 2022
F3n67u pushed a commit to F3n67u/jest that referenced this issue May 2, 2022
@github-actions
Copy link

github-actions bot commented May 28, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants