Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expect-utils): Fix deep equality of ImmutableJS Lists #12763

Merged
merged 2 commits into from
May 2, 2022

Conversation

romellem
Copy link
Contributor

Summary

Fixes #12752

Test plan

I could add a test case for iterableEquality, but I'd need to introduce immutable as a dev dependency. Let me know if you'd like to. Otherwise, this relies on the fact that immutable's List implements a similar API to native Set objects, importantly, .has().

@facebook-github-bot
Copy link
Contributor

Hi @romellem!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@SimenB
Copy link
Member

SimenB commented Apr 28, 2022

I could add a test case for iterableEquality, but I'd need to introduce immutable as a dev dependency. Let me know if you'd like to.

Yes please, a dev dep is perfectly fine! (we already have one in pretty-format 🙂 )

@SimenB
Copy link
Member

SimenB commented Apr 28, 2022

Seems this broke some other tests we have, actually

@romellem
Copy link
Contributor Author

Thanks, I'll add the new tests and look at the errors on the existing tests a little later on.

Some of their internal properties may not match, but they should be
considered equal.
@romellem
Copy link
Contributor Author

Didn't read the logic carefully enough for Sets, it isn't checking order (which makes sense). So instead we don't do the entries check if the objects are Lists.

Co-authored-by: Tom Mrazauskas <tom@mrazauskas.de>
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable, thanks!

@SimenB SimenB merged commit dd690ca into jestjs:main May 2, 2022
@romellem romellem changed the title fix(expect-utils): Treat ImmutableJS Lists as Sets fix(expect-utils): Fix deep equality of ImmutableJS Lists May 11, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Jest 28 fails on Immutable.List().filter toEqual comparison
4 participants