Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-environment-node): make performance writable #13467

merged 2 commits into from Oct 18, 2022


Copy link

@SimenB SimenB commented Oct 18, 2022


Ref nodejs/node#44626 (comment)

Note that there is a single failing test still: Runtime requireModule › resolves platform extensions based on the default platform


It's some weird haste thing - we should probably throw haste in a bin at some point 😅 There are cleaner ways of achieving custom resolution than polluting config with weird haste options.

Test plan

Running with nightly locally.

@SimenB SimenB merged commit e61ea77 into facebook:main Oct 18, 2022
64 of 65 checks passed
@SimenB SimenB deleted the node-19 branch October 18, 2022 12:52
Copy link
Collaborator Author

SimenB commented Oct 18, 2022

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants