Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: distribute rest files over shards #13476

merged 4 commits into from Oct 20, 2022

fix: distribute rest files over shards #13476

merged 4 commits into from Oct 20, 2022


Copy link


Sharding breaks execution by producing groups of length 0.

This was caused b naively using Math.ceil to determine the uniform shard size; this affects cases where both n % Math.ceil(n / s) === 0 and n % s !== 0 are true (n is number of tests, s is chosen shard count).

SimenB approved these changes Oct 19, 2022
Copy link

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a changelog entry?

also, ESLint with type info is unhappy 🙂 run yarn lint-ts-files locally to see

packages/jest-test-sequencer/src/index.ts Outdated Show resolved Hide resolved
@SimenB SimenB changed the title fix: distribute rest files over shards #13027 fix: distribute rest files over shards Oct 20, 2022
@SimenB SimenB merged commit 571c940 into facebook:main Oct 20, 2022
78 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

[Bug]: default jest config will sometimes result in shards with 0 tests
3 participants