Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.todo tests are shown as todo when inside a focussed describe #13504

merged 5 commits into from Oct 24, 2022


Copy link


Fix #13482 by changing .todo tests to not be marked as skipped when inside of a focussed describe block.

Test plan

I've added an e2e test for this case and no other tests should break

SimenB approved these changes Oct 24, 2022
Copy link

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@SimenB SimenB merged commit abd7d83 into facebook:main Oct 24, 2022
78 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

[Bug]: Tests marked as .todo inside describe.only blocks are shown as "skipped"
3 participants