Run setupTestFrameworkScriptFile after extendJasmineExpect #1731
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #1730. Having setupTestFrameworkScriptFile run after extendJasmineExpect makes sure that it is possible to override global.expect to use another expectation library like chai.
Test plan
A demo of jest working with chai is here: 0xR/snapshot-experiments#1.
You can run
npm test
which will run the tests which have chai assertions. The integrate-chai fork of jest-jasmine2 is installed to demo that the codes solves the issue.Future work
Document how to use jest with chai.