Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect npm client in SummaryReporter #3263

Merged
merged 1 commit into from
Apr 5, 2017

Conversation

thymikee
Copy link
Collaborator

@thymikee thymikee commented Apr 5, 2017

Summary

Fixes #3262

Test plan

$ npm test
Snapshot Summary
 › 1 obsolete snapshot found, run with `npm test -- -u` to remove them.

screen shot 2017-04-05 at 20 12 51

$ yarn test
Snapshot Summary
 › 1 obsolete snapshot found, run with `yarn test -- -u` to remove them.

screen shot 2017-04-05 at 20 12 47

@vjeux
Copy link
Contributor

vjeux commented Apr 5, 2017

Awesome, thanks for fixing those small things :)

@codecov-io
Copy link

Codecov Report

Merging #3263 into master will decrease coverage by 0.65%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3263      +/-   ##
==========================================
- Coverage   64.25%   63.59%   -0.66%     
==========================================
  Files         175      175              
  Lines        6435     6434       -1     
  Branches        4        4              
==========================================
- Hits         4135     4092      -43     
- Misses       2299     2341      +42     
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-cli/src/reporters/SummaryReporter.js 26.66% <0%> (-0.46%) ⬇️
packages/jest-message-util/src/index.js 0% <0%> (-100%) ⬇️
packages/jest-matcher-utils/src/index.js 70.27% <0%> (-28.38%) ⬇️
packages/jest-message-util/src/messages.js 72.36% <0%> (-14.48%) ⬇️
.../jest-message-util/src/separateMessageFromStack.js 80% <0%> (-10%) ⬇️
packages/jest-mock/src/index.js 89.54% <0%> (-2.28%) ⬇️
...s/jest-editor-support/src/parsers/BabylonParser.js 98.93% <0%> (-0.02%) ⬇️
packages/jest-cli/src/watch.js 64.61% <0%> (ø) ⬆️
packages/jest-config/src/normalize.js 89.54% <0%> (ø) ⬆️
...est-test-typescript-parser/src/TypeScriptParser.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a4417e...b86119d. Read the comment docs.

@aaronabramov aaronabramov merged commit b93f9c6 into jestjs:master Apr 5, 2017
@cpojer
Copy link
Member

cpojer commented Apr 11, 2017

Lovely!

@thymikee thymikee deleted the detect-npm-client branch April 19, 2017 02:51
skovhus pushed a commit to skovhus/jest that referenced this pull request Apr 29, 2017
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error message for removed tests
6 participants