Fix snapshot serializer require, restructure pretty-format. #3399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3399 +/- ##
==========================================
- Coverage 64.27% 64.16% -0.11%
==========================================
Files 176 176
Lines 6538 6530 -8
Branches 4 4
==========================================
- Hits 4202 4190 -12
- Misses 2335 2339 +4
Partials 1 1
Continue to review full report at Codecov.
|
cpojer
force-pushed
the
master
branch
2 times, most recently
from
036586d
to
413b752
Compare
thymikee
reviewed
Apr 28, 2017
| module.exports = { | ||
| process(src, filename, config, options) { | ||
| if (/bar.js$/.test(filename)) { | ||
| return `${src};\module.exports = createPlugin('bar');`; |
There was a problem hiding this comment.
I think the backslash (\) is a little confusing here at the first look. Can we remove it?
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3284 by not bypassing the user defined transform pipeline.
This also enables proper typing for pretty-format plugins within the Jest repo and stops reaching into
buildfiles, which Jest should never do, by exporting the plugins directly.Test plan
jest