Replace print with serialize in HTMLElement plugin #4215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4215 +/- ##
==========================================
- Coverage 60.19% 60.13% -0.06%
==========================================
Files 191 191
Lines 6766 6756 -10
Branches 6 6
==========================================
- Hits 4073 4063 -10
Misses 2690 2690
Partials 3 3
Continue to review full report at Codecov.
|
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* Replace print with serialize in HTMLElement plugin * Add comment about keysMapper and propsReducer
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support
indentationanddeptharguments. Enforce consistent printing of attributes/props.After reading about
Element.attributesandNode.childNodesWeb API docs on MDN, I removed some conditional expressions that seemed to protect against absence of the properties.Future follow up: To understand how much of whitespace trimming affects significant text content (see comments in test file) I will study some realistic examples, especially HTML rendered by React.
Test plan
Added 3 new fail-first tests.