Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove eslint-plugin-jest #4867

Merged
merged 2 commits into from
Nov 9, 2017
Merged

Remove eslint-plugin-jest #4867

merged 2 commits into from
Nov 9, 2017

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Nov 9, 2017

Summary
As talked about in private, we've decided to move the eslint plugin out of this repo, and into jest-community. The new home is here: https://github.com/jest-community/eslint-plugin-jest

@jkimbo Do you want to be a collaborator on that project?

Test plan
Still green CI

@codecov-io
Copy link

codecov-io commented Nov 9, 2017

Codecov Report

Merging #4867 into master will decrease coverage by 0.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4867      +/-   ##
==========================================
- Coverage   59.24%   58.46%   -0.79%     
==========================================
  Files         200      194       -6     
  Lines        6647     6517     -130     
  Branches        3        4       +1     
==========================================
- Hits         3938     3810     -128     
+ Misses       2709     2707       -2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a2429e...aec2bf0. Read the comment docs.

@jkimbo
Copy link
Contributor

jkimbo commented Nov 9, 2017

@SimenB sure, happy to be!

@cpojer cpojer merged commit d6b7448 into jestjs:master Nov 9, 2017
@cpojer
Copy link
Member

cpojer commented Nov 9, 2017

Awesome, thanks for doing this. I would still maintain that this eslint plugin, originally built by @jkimbo, is an official part of Jest. However, because the code itself has nothing to do with Jest itself, it makes sense to live in a separate repo.

We should update the docs for Jest to encourage people to install this eslint plugin, btw.

@SimenB SimenB deleted the remove-lint-plugin branch November 9, 2017 08:48
Arcanemagus added a commit to jfmengels/eslint-rule-documentation that referenced this pull request Jan 8, 2018
The `eslint-plugin-jest` package was moved to the `jest-community`
organization in jestjs/jest#4867.
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants