Standardize filenames in packages/jest circus

[andrew-pyle]

Summary

References Standardize file naming #4969.

Updates naming in package jest-circus. Uses conventions listed in #4969 (comment):

• Files that primarily export types, objects or classes should use CapitalizedFileNames.js and should mirror what’s inside 1:1.
• Files that export a single function should have the function name with camelCase in it.
• Folder names should use dashes, unless they are special folders.

Decisions

• Test & Mock files retained their name, but converted it to camelCase
• formatNodeAssertErrors.js had an export of the format

  export default (parameter: type...) => {}

  which was converted to the following to let the filename mirror the exported function.

  const formatNodeExceptionErrors = (parameter: type...) => {}
  // rest of file
  export default formatNodeExceptionErrors

• error_handlers.js was renamed globalErrorHandlers.js to more closely match the two exported functions: injectGlobalErrorHandlers & restoreGlobalErrorHandlers
• Thelegacy-code-todo-rewrite directory was renamed, but the Javascript files inside were not renamed. It seems like a good way to help get them rewritten?

Test plan

Output of yarn run test on master and standardize filenames in packages/jest circus branches was the same, with the exception of one test which failed on master, but not this branch. Not sure what would cause that.

FAIL  examples/manual-mocks/__tests__/lodashMocking.test.js
  ● if lodash head is mocked

    expect(received).toEqual(expected)

    Expected value to equal:
      5
    Received:
      2

      4 | 
      5 | test('if lodash head is mocked', () => {
    > 6 |   expect(lodash.head([2, 3])).toEqual(5);
        |                               ^
      7 | });
      8 | 

      at Object.toEqual (__tests__/lodashMocking.test.js:6:31)

jest-tests-master.txt
jest-tests-standardize-filenames-in-packages-jest-circus.txt

[thymikee]

Still some files left to rename

[thymikee]

runTest was a good name, please revert

[andrew-pyle]

I'll rename testUtils to runTest. Leave the filename testUtils?

[thymikee]

yup, leave it was :)

[andrew-pyle]

Which files are left to rename?

[thymikee]

[andrew-pyle]

Very good. I'll rename those as well

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.