[jest-each] Add primitive pretty printing #7694
Conversation
mattphillips
force-pushed
the
jest-each-primitive
branch
from
c3e498c
to
e7a5186
Compare
Codecov Report
@@ Coverage Diff @@
## master #7694 +/- ##
==========================================
+ Coverage 68.27% 68.28% +0.01%
==========================================
Files 251 251
Lines 9667 9671 +4
Branches 5 5
==========================================
+ Hits 6600 6604 +4
Misses 3065 3065
Partials 2 2
Continue to review full report at Codecov.
|
| @@ -23,6 +24,13 @@ const RECEIVED_COLOR = chalk.red; | |||
| const SUPPORTED_PLACEHOLDERS = /%[sdifjoOp%]/g; | |||
| const PRETTY_PLACEHOLDER = '%p'; | |||
| const INDEX_PLACEHOLDER = '%#'; | |||
| const PRIMITIVES = new Set([ | |||
There was a problem hiding this comment.
Not blocking at all, but we might consider moving this to jest-get-types (e.g.: isPrimitiveType(getType(value))).
There was a problem hiding this comment.
@rubennorte yup good shout, I'll send another PR for this change so we can merge this PR in the meantime :)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Closes: #7689
Test plan