Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow moduleFileExtensions without 'js' for custom runners #7751

Merged
merged 4 commits into from
Jan 29, 2019

Conversation

jeysal
Copy link
Contributor

@jeysal jeysal commented Jan 29, 2019

Summary

Fixes #7736

@SimenB Did end up doing the check in the config 😅 This still feels like weird coupling with jest-runners implementation details, but I tried throwing in jest-runner and it was just bad UX because it took so long to get to that point - plus there was no good place to throw without spamming the error for every test :/

Test plan

Added normalize test

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, otherwise lgtm 🙂 Thanks!

packages/jest-config/src/normalize.js Outdated Show resolved Hide resolved
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

moduleFileExtensions must include 'js'
3 participants