Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jest-jasmine2: fix describe return value warning being shown if describe throws #8335

Merged
merged 2 commits into from Apr 16, 2019

Conversation

Projects
None yet
4 participants
@jeysal
Copy link
Collaborator

commented Apr 15, 2019

Summary

Fixes the describe warning part of #8334 (intentionally not marking this as closing the whole issue)

Test plan

Added e2e test case that fails with master build (the stdout toBe('') check).

@jeysal jeysal changed the title fix describe return value warning being shown if describe throws jest-jasmine2: fix describe return value warning being shown if describe throws Apr 15, 2019

@jeysal jeysal requested review from SimenB and thymikee Apr 15, 2019

@SimenB

SimenB approved these changes Apr 16, 2019

@jeysal jeysal force-pushed the jeysal:describe-return-value-warning-fix branch from 5423a16 to 9efacb6 Apr 16, 2019

@jeysal jeysal merged commit b9c5df8 into facebook:master Apr 16, 2019

11 checks passed

ci/circleci: lint-and-typecheck Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-jest-circus Your tests passed on CircleCI!
Details
ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
ci/circleci: test-node-6 Your tests passed on CircleCI!
Details
ci/circleci: test-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
facebook.jest #20190416.1 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.