Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare global prototype in JSDOMEnvironment to fix issue #8347 #8352

Merged
merged 4 commits into from Apr 21, 2019

Conversation

Projects
None yet
5 participants
@lamhieu-vk
Copy link
Contributor

commented Apr 20, 2019

I have described an issue at #8347.
We know ignores were not emitted by Typescript creating declaration files (ref microsoft/TypeScript#20360) and we can't build in your Typescript project if not skip checking types in libraries using.

I re-declared global prototype in JSDOMEnvironment class. I checked in my project and build files.

@SimenB
Copy link
Collaborator

left a comment

Thanks!
Could you update the changelog? :)

Show resolved Hide resolved packages/jest-environment-jsdom/src/index.ts
Show resolved Hide resolved packages/jest-environment-jsdom/src/index.ts Outdated
@lamhieu-vk

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2019

@SimenB I updated PR and changelog.

@codecov-io

This comment has been minimized.

Copy link

commented Apr 21, 2019

Codecov Report

Merging #8352 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8352      +/-   ##
==========================================
+ Coverage   62.18%   62.18%   +<.01%     
==========================================
  Files         266      266              
  Lines       10704    10703       -1     
  Branches     2604     2604              
==========================================
  Hits         6656     6656              
+ Misses       3462     3461       -1     
  Partials      586      586
Impacted Files Coverage Δ
packages/jest-environment-jsdom/src/index.ts 37.77% <ø> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31e06e8...edac719. Read the comment docs.

@SimenB SimenB requested a review from jeysal Apr 21, 2019

@lamhieu-vk

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2019

@SimenB @jeysal Thank you very much for helping me clarify the problem!
I updated PR and it ready to merge!

@SimenB

SimenB approved these changes Apr 21, 2019

@SimenB SimenB merged commit 72c920e into facebook:master Apr 21, 2019

10 of 11 checks passed

ci/circleci: test-node-6 Your tests failed on CircleCI
Details
ci/circleci: lint-and-typecheck Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-jest-circus Your tests passed on CircleCI!
Details
ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
ci/circleci: test-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
facebook.jest #20190421.6 succeeded
Details

@lamhieu-vk lamhieu-vk deleted the lamhieu-vk:bugfix/Issue-8347 branch Apr 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.