chore: upgrade dependencies #8372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Apr 24, 2019
| @@ -892,7 +892,7 @@ const jestExpect = require('../'); | |||
| }).toThrowErrorMatchingSnapshot(); | |||
| }); | |||
|
|
|||
| test(`incomplete recursive calls are handled properly`, () => { | |||
| test('incomplete recursive calls are handled properly', () => { | |||
There was a problem hiding this comment.
SimenB
commented
Apr 24, 2019
| @@ -85,14 +85,14 @@ it('uses the blacklist to avoid copying properties on the first level', () => { | |||
|
|
|||
| it('does not keep the prototype by default when top level is object', () => { | |||
| // @ts-ignore | |||
| const sourceObject = new function() {}(); | |||
| const sourceObject = new (function() {})(); | |||
SimenB
commented
Apr 24, 2019
| "pretty-format": "^24.7.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/camelcase": "^4.1.0", | ||
| "@types/leven": "^2.1.1" |
There was a problem hiding this comment.
leven comes with type defs now
|
Not sure what's up with the error messages for jasmine or the |
Closed
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The dependencies left to upgrade either require node 8, is micromatch or are covered by #8370
Test plan
Green CI