Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] changed react-testing-library package name to @testing-library/react #8753

Merged
merged 7 commits into from Jul 27, 2019

Conversation

@jdelucaa
Copy link
Contributor

jdelucaa commented Jul 26, 2019

Updated react-testing-library package name to @testing-library/react in docs.

Summary

react-testing-library package has been moved (testing-library/dom-testing-library#260) and for new versions @testing-library/react should be installed instead of react-testing-library.

Please let me know if you think it is necessary to change versioned docs as well.

Test plan

I installed react-testing-library in my local project and got the following message:

npm WARN deprecated react-testing-library@8.0.1: � react-testing-library has moved to @testing-library/react. Please uninstall react-testing-library and install @
testing-library/react instead, or use an older version of react-testing-library. Learn more about this change here: testing-library/dom-testing-library#260 Thanks! :)

Besides that, in this PR only documentation has been updated, no code breaking changes.

@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Jul 26, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Joana Deluca Kleis
@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Jul 26, 2019

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@SimenB

This comment has been minimized.

Copy link
Collaborator

SimenB commented Jul 26, 2019

This will fail on node 6. Can you update the circle ci config to delete it on node 6 similar to the react native example?

(Ignore the circle failure on ci)

@SimenB

This comment has been minimized.

Copy link
Collaborator

SimenB commented Jul 26, 2019

Oh, these are just doc changes 😅 Could you update https://github.com/facebook/jest/tree/master/examples/react-testing-library as well? You run the example locally by doing yarn && yarn jest react-testing-library

And yes, please update the versioned docs 🙂

@jdelucaa

This comment has been minimized.

Copy link
Contributor Author

jdelucaa commented Jul 26, 2019

@SimenB yes, just noticed the imports would need to be updated as well.. 😅
I'll do it.

@SimenB
SimenB approved these changes Jul 26, 2019
examples/react-testing-library/package.json Outdated Show resolved Hide resolved
Joana Deluca Kleis
@SimenB SimenB merged commit 8902dbe into facebook:master Jul 27, 2019
10 of 11 checks passed
10 of 11 checks passed
ci/circleci: test-jest-circus Your tests failed on CircleCI
Details
ci/circleci: lint-and-typecheck Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
ci/circleci: test-node-6 Your tests passed on CircleCI!
Details
ci/circleci: test-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
facebook.jest #20190726.16 succeeded
Details
@SimenB

This comment has been minimized.

Copy link
Collaborator

SimenB commented Jul 27, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.