Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: deleteWordBackward/deleteWordForward getTargetRanges handling of tab whitespace #148

Closed
trueadm opened this issue Mar 2, 2021 · 0 comments · Fixed by #202
Closed

Bug: deleteWordBackward/deleteWordForward getTargetRanges handling of tab whitespace #148

trueadm opened this issue Mar 2, 2021 · 0 comments · Fixed by #202

Comments

@trueadm
Copy link
Collaborator

trueadm commented Mar 2, 2021

I believe this is soemwhat related to #66.

When executing a deleteWordBackward and deleteWordForward on text that contains a tab when using getTargetRanges on Chrome (maybe Safari), it removes the tab as part of the word. Our polyfill doesn't do this, which @steveluscher mentioned was the expected behavior.

What do we do with this? If native beforeinput does this in all browsers, then maybe that is the correct thing to do, and we should update our polyfills?
@trueadm trueadm changed the title deleteWordBackward/deleteWordForward bug with tabs Bug: deleteWordBackward/deleteWordForward getTargetRanges handling of tab whitespace Mar 2, 2021
@trueadm trueadm mentioned this issue Apr 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Major selection refactor facebook/lexical
2 participants
@steveluscher @trueadm