Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: correcting a word using Grammarly will also insert word where the cursor is if in a different paragraph. #3428

Closed
scvet-ct opened this issue Nov 25, 2022 · 3 comments · Fixed by #3429
Assignees

Comments

@scvet-ct
Copy link

Lexical version: 0.5.0

Steps To Reproduce

  1. enable grammarly extension (turn off autocorrect)
  2. write a paragraph
  3. start a new paragraph with an incorrectly spelled word.
  4. click back into the previous paragraph
  5. hover over the incorrectly spelled word (don't click on it) and then click on Grammarly's suggested change to select it
  6. the word will change but also be placed in the previous paragraph where the cursor is.

Link to code example:
This happens in the current version of Lexical Playground.

The current behavior

image

image

The expected behavior

image

image

@scvet-ct
Copy link
Author

Thanks for taking a look at this so quickly. Sorry if I've missed something, however, I see the fix has been deployed but the issue is persisting on the playground. To reproduce the carat must be clicked in a different paragraph to the word you are changing with Grammarly.

@trueadm
Copy link
Collaborator

trueadm commented Nov 28, 2022

I'm a muppet and somehow undid the fix before landing that PR. I fixed in #3438.

@scvet-ct
Copy link
Author

Amazing, thank you for fixing it so quickly. Will update our version of lexical when it's in main 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants