Bug: Pasting lists on lists results in potentially reordered content

[9larsons]

Lexical version: v0.11.1

Steps To Reproduce

1. Create a list item with a child list item
2. Paste text and list onto that content (see gif)

The current behavior

See gif above. Pasted content can be re-ordered relative to what was in the document which is definitely unintentional (ie not all pasted content is inserted at the same spot).

The expected behavior

I'd expect content to be pasted and at least maintain the correct ordering. I feel like the indentation behavior is subjective. For example, Google Docs will paste lists relative to the current indendation/list depth, while Lexical appears to paste relative to parent nodes.

[9larsons]

I believe the issue is definitely within this block. If I can find some time I'll do some more investigation.

[9larsons]

This cannot be resolved while #5124 is out there, as the behavior that is intended to handle the node insertion is broken by the fact that an empty ElementNode is inserted prior to the content that was actually intended to be inserted (by way of copy actions in the editor).

You can test this by pasting from outside the editor, like a list from google docs, and it pastes in just fine (and as we'd expect it). The reason the re-order happens is because it ends up being treated as a whole new ListNode vs. a ListItemNode.

[9larsons]

To be clear, this is the line where it fouls up. The firstAncestor ends up being a ListItemNode and not a TextNode if it's empty (and in this case we're always adding an empty line).

Because of this, it ends up getting appended to the end instead of inserted as one would expect.

[ivailop7]

@9larsons are you open to fixing this upstream?

[9larsons]

This seems resolved when testing again in v0.13.1 - seems likely it was handled with the changes to insertNodes.