keep selection style when clicking empty editor #5292
Conversation
youngkyo0504
requested review from
zurfyx,
fantactuka and
acywatson
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @youngkyo0504! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
@youngkyo0504 can you sign the CLA and I'm OK with merging this. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
Thank you! I have signed the CLA 😁 |
| @@ -11,6 +11,7 @@ import type {NodeKey} from './LexicalNode'; | |||
| import type {ElementNode} from './nodes/LexicalElementNode'; | |||
| import type {TextNode} from './nodes/LexicalTextNode'; | |||
|
|
|||
| import {$isRootTextContentEmpty} from '@lexical/text'; | |||
There was a problem hiding this comment.
I don't think we should create this dependency between the core and @lexical/text
There was a problem hiding this comment.
how about using this instead of delete dependency?
const root = $getRoot();
isRootEmpty root.getTextContent() === ''There was a problem hiding this comment.
I added commit which delete dependency between the core and @lexical/text
resolve #5202
change code to keep selection style when clicking editor which has empty content.
beforeLexical.Playground.Bug.mov
after2023-11-28.1.39.43.mov