Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Inserting hyperlink through toolbar doesn't open floating editor in edit mode" #5456

Merged
merged 1 commit into from Jan 6, 2024
Merged

Revert "Inserting hyperlink through toolbar doesn't open floating editor in edit mode" #5456

merged 1 commit into from Jan 6, 2024

Conversation

acywatson
Copy link
Contributor

Reverts #5372

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 6, 2024
@vercel Vercel
Copy link

vercel bot commented Jan 6, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2024 7:07pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2024 7:07pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.68 KB (0%) 534 ms (0%) 231 ms (+35.37% 🔺) 764 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.39 KB (0%) 788 ms (0%) 355 ms (-4.77% 🔽) 1.2 s
packages/lexical-plain-text/dist/LexicalPlainText.js 39.36 KB (0%) 788 ms (0%) 331 ms (+14.39% 🔺) 1.2 s

@acywatson acywatson merged commit 14554bf into main Jan 6, 2024
45 checks passed
@2wheeh 2wheeh mentioned this pull request Jan 7, 2024
Merged
amanharwara pushed a commit to standardnotes/lexical that referenced this pull request Jan 18, 2024
@acywatson @amanharwara
Revert "Inserting hyperlink through toolbar doesn't open floating edi…
ea6f03f 
…tor in edit mode" (facebook#5456)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegreatercurve thegreatercurve thegreatercurve approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@acywatson @thegreatercurve @facebook-github-bot