Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small issue with DecoratorNode type guards #5478

Merged
merged 1 commit into from Jan 11, 2024

Conversation

thegreatercurve
Copy link
Contributor

@thegreatercurve thegreatercurve commented Jan 11, 2024

These shouldn't be mixed by default, but should accept a generic to specify the actual return type.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 11, 2024
Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 10:23pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 10:23pm

@thegreatercurve thegreatercurve changed the title Fix small issue with decorator node type Fix small issue with DecoratorNode type guards Jan 11, 2024
@thegreatercurve thegreatercurve marked this pull request as ready for review January 11, 2024 22:21
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.68 KB (0%) 534 ms (0%) 186 ms (-3.58% 🔽) 720 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.4 KB (0%) 788 ms (0%) 262 ms (+19.51% 🔺) 1.1 s
packages/lexical-plain-text/dist/LexicalPlainText.js 39.37 KB (0%) 788 ms (0%) 187 ms (-34.89% 🔽) 974 ms

@thegreatercurve thegreatercurve merged commit 90137e5 into main Jan 11, 2024
45 checks passed
amanharwara pushed a commit to standardnotes/lexical that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants