Use bit flag instead of booleans in TestDrawableComponent

[emilsjolander]

We have a lot of booleans to configure the test components like callsShouldUpdateOnMount or implementsAccessibility. Instead of keeping the configuration flags as booleans we could have them as bit flags.

Code pointers

https://github.com/facebook/litho/blob/master/litho-testing/src/main/java/com/facebook/litho/testing/TestDrawableComponent.java

Point of contact: @mihaelao

[anu0012]

Hey @emilsjolander, I want to take up this issue. Can you guide me? Do we need to use bit flags just like it is used in InternalNode.java file?

https://github.com/facebook/litho/blob/master/litho-core/src/main/java/com/facebook/litho/InternalNode.java

[emilsjolander]

Awesome! Yes I believe so. Will delegate specifics to @mihaelao who is the POC for this issue 👍 She should be able to provide more specific guidance.

[anu0012]

Hey @mihaelao, I have some doubt regarding this issue. Do we also need to change the return types of methods like callsShouldUpdateOnMount() etc?

[mihaelao]

Hi @anu0012, thanks for taking this up! You're right, the idea is to use bit flags instead of booleans, same as for InternalNode. The API shouldn't change though, those methods should still return booleans, but you can perform bitwise operations on the flags instead of returning the booleans directly.

[muraziz]

Resolved with #138