Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to build new py3 thrift changes in upstream #407

Open
vivsy opened this issue Mar 14, 2023 · 0 comments
Open

unable to build new py3 thrift changes in upstream #407

vivsy opened this issue Mar 14, 2023 · 0 comments

Comments

@vivsy
Copy link

vivsy commented Mar 14, 2023

Hi, we pulled in the new changes from upstream that included the addition of the py3 namespace to some of the thrift files as well as some python tests trying to use the generated python file- however, I don't think the file was generated on our end and thus the tests errored out.

I tried looking at the corresponding cpp files that fbthrift generated and noticed that there was a lot more explicit definition of those files in the Makefile.am but I didn't see the same for the python files. Wondering if there's anything that I missed or if we need to somehow manually generate the python files? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant