Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemLab cannot analyze heap across page reloads #20

Closed
applesaucesome opened this issue Sep 14, 2022 · 2 comments
Closed

MemLab cannot analyze heap across page reloads #20

applesaucesome opened this issue Sep 14, 2022 · 2 comments

Comments

@applesaucesome
Copy link

I'm trying to use Memlab on my app that is login protected. The login process causes a redirect to the login page and then redirects back to my app after a successful login. This causes the error "The page is reloaded. MemLab cannot analyze heap across page reloads. Please remove window.reload() calls or disable any reload logic."

Are there any plans to enable Memlab to work with apps that have this login flow?

@JacksonGL
Copy link
Member

@applesaucesome MemLab test scenario (with action and back callback) finds memory leaks by diffing heap snapshots. If the web page reloads, diffing heap snapshot doesn't make sense since browser refreshes the JS heap.

Have you tried the cookies callback?

We may be able to support start checking reload after the setup call so you can do the login with reloading inside the setup callback.

MemLab also supports finding memory leaks based on a single heap snapshot taken manually from Chrome.

memlab view-heap --snapshot <path to .heapsnapshot file>

@applesaucesome
Copy link
Author

@JacksonGL I'll give these alternate approaches a try, thank you!! Also, I support the idea of being able to pick when the check starts, like you're suggesting. I think it could be a more flexible approach for these login/redirect scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants