fix support for node v4 #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jeanlauliac
commented
Jun 26, 2017
| @@ -17,6 +17,8 @@ | |||
| * node ./scripts/build.js /user/c/metro-bundler/packages/metro-abc/src/abc.js | |||
| */ | |||
|
|
|||
| 'use strict'; | |||
There was a problem hiding this comment.
Needed to use let and const on Node v4.
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=======================================
Coverage 85.24% 85.24%
=======================================
Files 79 79
Lines 3232 3232
Branches 469 469
=======================================
Hits 2755 2755
Misses 427 427
Partials 50 50Continue to review full report at Codecov.
|
|
lgtm, thank you for the fix! |
|
@davidaurelio has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node v4 support has been broken for some time, with CircleCI failing tests. That's because it needs an additional transform for the spread operator in call position. Ex
foo(...smth)expanding tofoo.apply(null, smth). Also, the build script was using syntax not supported by Node v4.This changeset fixes the build script, and adds the missing transform. This will be used both for jest test and for the produced production output. This is needed for prod output since we want it to be able to be ran on Node v4 out-of-the-box.
CircleCI will confirm these changes work properly on all supported versions of Node.