Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] HMR with multiple clients #8

Closed
brentvatne opened this issue Jun 9, 2017 · 4 comments
Closed

[Feature] HMR with multiple clients #8

brentvatne opened this issue Jun 9, 2017 · 4 comments

Comments

@brentvatne
Copy link
Contributor

What is the current behavior?

  1. Create a new react-native project either with react-native-cli or create-react-native-app
  2. Open app on simulator
  3. Open app on device
  4. Disable live reloading and enable hot reloading on both of them
  5. Make changes
  6. Only the most recently connected client will update

What is the expected behavior?

Both clients should hot reload

Please provide your exact metro-bundler configuration and mention your metro-bundler, node, yarn/npm version and operating system.

Default react-native configuration for 0.45 (react-native-cli) and 0.44 (create-react-native-app). This is a longstanding issue that as far as I know has been present since the inception of HMR in react-native. Yarn 0.24., macOS 10.12.4

@linnett
Copy link

linnett commented Jun 9, 2017

+1

@cpojer
Copy link
Contributor

cpojer commented Jun 10, 2017

The HMR code is still in react-native/local-cli.

@cpojer cpojer closed this as completed Jun 10, 2017
@brentvatne
Copy link
Contributor Author

@cpojer - is it moving here? if so, where's the best place for this issue? I imagine it will just be ignored or closed on react-native and then have to be re-opened here if it moves to metro

@cpojer
Copy link
Contributor

cpojer commented Jun 11, 2017

It may move here but for now the code is in react-native and the change needs to be made there. Sorry about the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants