python fbcode_builder/make_docker_context.py produces corrupt Dockerfile

[ghost]

Issue Description

python fbcode_builder/make_docker_context.py puts ' (single-quotes) around many values, states in Dockerfile. Probably by echo-ing variables to output and encapsulate them wrong.

Environment

• Current head 5b06765dbf2dc1a1bfc4d83ca47e0ca3f0a129b4
• Linux stretch 4.9.0-8-amd64 #1 SMP Debian 4.9.130-2 (2018-10-27) x86_64 GNU/Linux from Vagrants debian/stretch64 (9.6.0)

Minimal test code / Steps to reproduce the issue

# clone openr
# follow build/README.md
# Run Step 1
# Run Step 2
# error, cmake can not even compile the test program

What's the actual result?

You can not use the build env...

What's the expected result?

Getting the build env finished without errors to have a look at open/r ;)

Fix

sed -ie "s/'//g" Dockerfile

[saifhhasan]

Our travis build is able to generate as well as execute generated Docker context - https://travis-ci.org/facebook/openr

Not sure if it related to python version. Will appreciate a pull request if you happen to fix it.

[saifhhasan]

Closing due to inactivity and issue couldn't re-produce on our travis CI