Docker build fails on current release and on master

[butjar]

Please use this template for reporting suspected bugs or requests for help.

Issue Description

Current docker build fails

Environment

• sha: d706183
• Docker

Minimal test code / Steps to reproduce the issue

cd openr/build
python fbcode_builder/make_docker_context.py
cd /tmp/docker-context-XXX
sudo docker build -t openr-build . | tee log

What's the actual result?

The build step compiling OpenR fails with:

Step 207/211 : WORKDIR '/home'/'openr'/'build'
Removing intermediate container 36c56466aa5e
 ---> c72a0fcfed38
Step 208/211 : RUN CXXFLAGS="$CXXFLAGS -fPIC -isystem "'/home/install'"/include" CFLAGS="$CFLAGS -fPIC -isystem "'/home/install'"/include" cmake -D'CMAKE_INSTALL_PREFIX'='/home/install' -D'BUILD_SHARED_LIBS'='ON' -D'ADD_ROOT_TESTS'='OFF' '..'
 ---> Running in 4dba5f1c17ef
[...]
[ 29%] Building CXX object CMakeFiles/OpenrCtrl-cpp2-obj.dir/thrift-out/openr/if/gen-cpp2/OpenrCtrl_constants.cpp.o
In file included from /home/openr/build/thrift-out/openr/if/gen-cpp2/OpenrCtrl_constants.h:11:0,
                 from /home/openr/build/thrift-out/openr/if/gen-cpp2/OpenrCtrl_constants.cpp:8:
/home/openr/build/thrift-out/openr/if/gen-cpp2/OpenrCtrl_types.h:16:46: fatal error: openr/if/gen-cpp2/Decision_types.h: No such file or directory
compilation terminated.
CMakeFiles/OpenrCtrl-cpp2-obj.dir/build.make:102: recipe for target 'CMakeFiles/OpenrCtrl-cpp2-obj.dir/thrift-out/openr/if/gen-cpp2/OpenrCtrl_constants.cpp.o' failed
make[2]: *** [CMakeFiles/OpenrCtrl-cpp2-obj.dir/thrift-out/openr/if/gen-cpp2/OpenrCtrl_constants.cpp.o] Error 1
make[1]: *** [CMakeFiles/OpenrCtrl-cpp2-obj.dir/all] Error 2
CMakeFiles/Makefile2:703: recipe for target 'CMakeFiles/OpenrCtrl-cpp2-obj.dir/all' failed
Makefile:138: recipe for target 'all' failed
make: *** [all] Error 2
The command '/bin/bash -c PYTHONPATH="$PYTHONPATH:"'/home/install'/lib/python2.7/site-packages make -j '1'' returned a non-zero code: 2

For full logs and Dockerfile see:
full_log.zip

What's the expected result?

A successfully built docker container containing OpenR

[butjar]

Unfortunately, the current release doesn't seem to build either.

Step 49/221 : RUN make -j '1' VERBOSE=1
 ---> Running in c16cd4fa1907
[...]
[ 44%] Building CXX object CMakeFiles/FizzTool.dir/tool/FizzClientCommand.cpp.o
/usr/bin/c++    -I/home/fizz -isystem /home/install/include  -fPIC -isystem /home/install/include  -fPIE   -std=c++14 -o CMakeFiles/FizzTool.dir/tool/FizzClientCommand.cpp.o -c /home/fizz/fizz/tool/FizzClientCommand.cpp
[ 44%] Building CXX object CMakeFiles/FizzTool.dir/tool/FizzCommandCommon.cpp.o
/usr/bin/c++    -I/home/fizz -isystem /home/install/include  -fPIC -isystem /home/install/include  -fPIE   -std=c++14 -o CMakeFiles/FizzTool.dir/tool/FizzCommandCommon.cpp.o -c /home/fizz/fizz/tool/FizzCommandCommon.cpp
[ 45%] Building CXX object CMakeFiles/FizzTool.dir/tool/FizzServerCommand.cpp.o
/usr/bin/c++    -I/home/fizz -isystem /home/install/include  -fPIC -isystem /home/install/include  -fPIE   -std=c++14 -o CMakeFiles/FizzTool.dir/tool/FizzServerCommand.cpp.o -c /home/fizz/fizz/tool/FizzServerCommand.cpp
/home/fizz/fizz/tool/FizzServerCommand.cpp:74:8: error: 'void fizz::tool::{anonymous}::FizzServerAcceptor::connectionAccepted(folly::NetworkSocket, const folly::SocketAddress&)' marked 'override', but does not override
   void connectionAccepted(
        ^
/home/fizz/fizz/tool/FizzServerCommand.cpp: In function 'int fizz::tool::fizzServerCommand(const std::vector<std::__cxx11::basic_string<char> >&)':
/home/fizz/fizz/tool/FizzServerCommand.cpp:625:22: error: cannot declare variable 'acceptor' to be of abstract type 'fizz::tool::{anonymous}::FizzServerAcceptor'
   FizzServerAcceptor acceptor(port, serverContext, loop, &evb, sslContext);
                      ^
/home/fizz/fizz/tool/FizzServerCommand.cpp:66:7: note:   because the following virtual functions are pure within 'fizz::tool::{anonymous}::FizzServerAcceptor':
 class FizzServerAcceptor : AsyncServerSocket::AcceptCallback {
       ^
In file included from /home/fizz/fizz/tool/FizzServerCommand.cpp:25:0:
/home/install/include/folly/io/async/AsyncServerSocket.h:160:18: note:  virtual void folly::AsyncServerSocket::AcceptCallback::connectionAccepted(int, const folly::SocketAddress&)
     virtual void connectionAccepted(
                  ^
CMakeFiles/FizzTool.dir/build.make:134: recipe for target 'CMakeFiles/FizzTool.dir/tool/FizzServerCommand.cpp.o' failed
make[2]: Leaving directory '/home/fizz/fizz/build'
make[2]: *** [CMakeFiles/FizzTool.dir/tool/FizzServerCommand.cpp.o] Error 1
CMakeFiles/Makefile2:533: recipe for target 'CMakeFiles/FizzTool.dir/all' failed
make[1]: *** [CMakeFiles/FizzTool.dir/all] Error 2
make[1]: Leaving directory '/home/fizz/fizz/build'
make: *** [all] Error 2
Makefile:138: recipe for target 'all' failed
The command '/bin/bash -c make -j '1' VERBOSE=1' returned a non-zero code: 2

full_log.zip

Can you point me to a stable commit ?

[saifhhasan]

Can you build new release ? We recently had few fixes and our travis CI as well as our internal CI using fbcode-builder are passing now.

Closing the issue. Please re-open if issue still persists

[butjar]

Still having the same result when building with docker:

[...]
Step 209/211 : RUN PYTHONPATH="$PYTHONPATH:"'/home/install'/lib/python2.7/site-packages make -j '1'
 ---> Running in ddebb50c816b
Scanning dependencies of target AllocPrefix-cpp2-target
[  0%] Generating AllocPrefix files. Output: /home/openr/build/thrift-out/openr/if
[...]
[ 35%] Built target Platform-cpp2-obj
Scanning dependencies of target OpenrCtrl-cpp2-target
[ 35%] Generating OpenrCtrl files. Output: /home/openr/build/thrift-out/openr/if
[ 35%] Built target OpenrCtrl-cpp2-target
Scanning dependencies of target OpenrCtrl-cpp2-obj
[ 35%] Building CXX object CMakeFiles/OpenrCtrl-cpp2-obj.dir/thrift-out/openr/if/gen-cpp2/OpenrCtrl_constants.cpp.o
In file included from /home/openr/build/thrift-out/openr/if/gen-cpp2/OpenrCtrl_constants.h:11:0,
                 from /home/openr/build/thrift-out/openr/if/gen-cpp2/OpenrCtrl_constants.cpp:8:
/home/openr/build/thrift-out/openr/if/gen-cpp2/OpenrCtrl_types.h:16:46: fatal error: openr/if/gen-cpp2/Decision_types.h: No such file or directory
compilation terminated.
CMakeFiles/OpenrCtrl-cpp2-obj.dir/build.make:102: recipe for target 'CMakeFiles/OpenrCtrl-cpp2-obj.dir/thrift-out/openr/if/gen-cpp2/OpenrCtrl_constants.cpp.o' failed
make[2]: *** [CMakeFiles/OpenrCtrl-cpp2-obj.dir/thrift-out/openr/if/gen-cpp2/OpenrCtrl_constants.cpp.o] Error 1
CMakeFiles/Makefile2:703: recipe for target 'CMakeFiles/OpenrCtrl-cpp2-obj.dir/all' failed
make[1]: *** [CMakeFiles/OpenrCtrl-cpp2-obj.dir/all] Error 2
make: *** [all] Error 2
Makefile:138: recipe for target 'all' failed

I'm building without ccache. BTW, the Dockerfile fetches always the latest commit anyways.

logs.zip

[butjar]

@saifhhasan Could you please check ?