Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create tests for the table certificates #5057

Closed
akindyakov opened this issue Aug 17, 2018 · 1 comment
Closed

Create tests for the table certificates #5057

akindyakov opened this issue Aug 17, 2018 · 1 comment
Labels
good-first-issue Well defined easy issue. Good for the beginning contribution. macOS test Windows

Comments

@akindyakov
Copy link
Contributor

Create tests for the table certificates

  • Create header file for the table implementation, if one is not exists.
  • In test, query the table and check if retrieved columns (name and types) match the columns from table spec.
  • If there is any guarantee to number of rows (e.g. only 1 record in every query result, more than 3 records or something else) check it.
  • Test the implementation details of the table, if it possible.

Table spec: specs/macwin/certificates.table

Source files:

  • osquery/tables/system/darwin/certificates.mm
  • osquery/tables/system/windows/certificates.cpp

Table generating function: genCerts()

Labels: good-first-issue build/test windows macos
@akindyakov akindyakov added build macOS Windows good-first-issue Well defined easy issue. Good for the beginning contribution. labels Aug 17, 2018
@directionless
Copy link
Member

Fixed in #5914

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Well defined easy issue. Good for the beginning contribution. macOS test Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@directionless @muffins @akindyakov