Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Processes name correctly displays uid for domain users #3574

Merged
merged 1 commit into from Aug 19, 2017

Conversation

muffins
Copy link
Contributor

@muffins muffins commented Aug 18, 2017

This addresses #3400 in which domain users uid value not showing up in either the users or processes table.

@facebook-github-bot facebook-github-bot added the cla signed Automated label: Pull Request author has signed the osquery CLA label Aug 18, 2017
@osqueryer
Copy link

🙅 The commit b314fcd (Job results: 2260) failed the code audit or documentation test.

@osqueryer
Copy link

👎 The commit b314fcd (Job results: 1660) failed one or more tests (macOS/OS X).

@muffins
Copy link
Contributor Author

muffins commented Aug 18, 2017

ok to test

@muffins
Copy link
Contributor Author

muffins commented Aug 18, 2017

Looks like memory leak in Jenkins github plugin?

Started by upstream project "osqueryPullRequestAudit" build number 2260
originally caused by:
 GitHub pull request #3574 of commit b314fcd15c7a60aed2d5814482d21a76e5e717f6, no merge conflicts.
Building remotely on aws-ubuntu-16.04 (i-0148349a4ef70f845) (aws-ubuntu-16.04) in workspace /var/jenkins/workspace/osqueryPullRequestAudit/TargetSystem/aws-ubuntu-16.04
[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Done
Cloning the remote Git repository
Cloning repository https://github.com/facebook/osquery.git
 > git init /var/jenkins/workspace/osqueryPullRequestAudit/TargetSystem/aws-ubuntu-16.04 # timeout=10
Fetching upstream changes from https://github.com/facebook/osquery.git
 > git --version # timeout=10
 > git fetch --tags --progress https://github.com/facebook/osquery.git +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url https://github.com/facebook/osquery.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
 > git config remote.origin.url https://github.com/facebook/osquery.git # timeout=10
Fetching upstream changes from https://github.com/facebook/osquery.git
 > git fetch --tags --progress https://github.com/facebook/osquery.git +refs/pull/*:refs/remotes/origin/pr/*
JENKINS-19022: warning: possible memory leak due to Git plugin usage; see: https://wiki.jenkins-ci.org/display/JENKINS/Remove+Git+Plugin+BuildsByBranch+BuildData
Checking out Revision e8017fa1f897b1386a206b8415a316f3020b689f (refs/remotes/origin/pr/3574/merge)
FATAL: hudson.remoting.Channel$OrderlyShutdown
Command close created at
	at hudson.remoting.Command.<init>(Command.java:60)
	at hudson.remoting.Channel$CloseCommand.<init>(Channel.java:1132)
	at hudson.remoting.Channel$CloseCommand.<init>(Channel.java:1130)
	at hudson.remoting.Channel.close(Channel.java:1290)
	at hudson.remoting.Channel.close(Channel.java:1272)
	at hudson.remoting.Channel$CloseCommand.execute(Channel.java:1137)
Caused: hudson.remoting.Channel$OrderlyShutdown
	at hudson.remoting.Channel$CloseCommand.execute(Channel.java:1138)
	at hudson.remoting.Channel$1.handle(Channel.java:535)
	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:83)
Caused: hudson.remoting.RequestAbortedException
	at hudson.remoting.Request.abort(Request.java:307)
	at hudson.remoting.Channel.terminate(Channel.java:905)
	at hudson.remoting.Channel$CloseCommand.execute(Channel.java:1138)
	at hudson.remoting.Channel$1.handle(Channel.java:535)
	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:83)
	at ......remote call to aws-ubuntu-16.04 (i-0148349a4ef70f845)(Native Method)
	at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1554)
	at hudson.remoting.Request.call(Request.java:172)
	at hudson.remoting.Channel.call(Channel.java:838)
	at hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:257)
	at com.sun.proxy.$Proxy68.withRepository(Unknown Source)
	at org.jenkinsci.plugins.gitclient.RemoteGitImpl.withRepository(RemoteGitImpl.java:235)
	at hudson.plugins.git.GitSCM.printCommitMessageToLog(GitSCM.java:1195)
	at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1159)
	at hudson.scm.SCM.checkout(SCM.java:495)
	at hudson.model.AbstractProject.checkout(AbstractProject.java:1212)
	at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:560)
	at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:485)
	at hudson.model.Run.execute(Run.java:1737)
	at hudson.matrix.MatrixRun.run(MatrixRun.java:146)
	at hudson.model.ResourceController.execute(ResourceController.java:97)
	at hudson.model.Executor.run(Executor.java:419)
Finished: FAILURE

@osqueryer
Copy link

👎 The commit b314fcd (Job results: 2444) failed one or more tests (Windows).

@osqueryer
Copy link

👎 The commit b314fcd (Job results: 2445) failed one or more tests (Windows).

@muffins
Copy link
Contributor Author

muffins commented Aug 19, 2017

ok to test

@muffins muffins merged commit 5172580 into osquery:master Aug 19, 2017
trizt pushed a commit to trizt/osquery that referenced this pull request May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cla signed Automated label: Pull Request author has signed the osquery CLA virtual tables Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants