New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a unicode parsing error #4310
Conversation
@obelisk has updated the pull request. |
@obelisk has updated the pull request. |
osquery/core/conversions.cpp
Outdated
} | ||
return Status(); | ||
return Status{0}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: why the initialization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind changing it back for consistency with the code base? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one nit.
@obelisk has updated the pull request. |
There was an error where having a query with a path like C:\users, osquery thought that was a unicode character
sers
after\u
.This adds a check for double backslashes and skips them if found.
What would happen before with the new testcase: